Going on what I started yesterday (building and trying the instrument stuff), I ran into trouble running the example app in instrument-manager. I've attached 2 path to fix the following issues:
1. bin/run.sh was somewhat out of date (looks like it dates from the altprofile time) 2. conf/instrument.xml was throwing ConfigurationException because average has been renamed to mean recently. I also ran into a lot a property definition problems with the ant.properties.sample file in the example dir. I fixed it on my machine but I'm not sure of the best way to handle it yet cause I'm not an ant expert - more of a basic user. Do we want to inherit from ant.properties files in parent dirs (as build.xml might suggest) or do we want to redefine all props locally? We could use property definitions from other files providing we define ${base.path} in the build file (and not in the ant.properties file, which causes wrong path resolution due to the relative addressing and files being at different directories level) and if all props are defined relative to this path. Or we can redefine all the props we need in each of the ant.properties files. Thoughts? -- Vincent P.S. I finally got to see that console and I fell in love with it :-) On Tue, 2002-04-23 at 12:13, Jeff Turner wrote: > On Tue, Apr 23, 2002 at 12:14:14AM +0000, Vincent Tence wrote: > > I've just tried a vanilla build of excalibur, which failed because > > ant.properties.sample and depchecker.xml were out of sync. > > > > The build file is expecting a property avalon-logkit.jar and > > ant.properties.sample defines logkit.jar. I have attached 2 patches, > > depending on where the correction should go. > > Thanks for that. I applied the ant.properties.sample one. > > There are similar inconsistencies in other ant.properties.sample files. > I'll go through them all soonish and fix them. I'm beginning to think > ${logkit.jar} is better than ${avalon-logkit.jar} anyway, since it > matches the actual jar name. For the record, I originally converted to > ${avalon-logkit.jar} for consistency with ${avalon-framework.jar} and > ${avalon-excalibur.jar}. > > > --Jeff > > > -- Vincent > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> >
Index: run.sh =================================================================== RCS file: /home/cvspublic/jakarta-avalon-excalibur/instrument-manager/example/bin/run.sh,v retrieving revision 1.1 diff -u -r1.1 run.sh --- run.sh 26 Mar 2002 11:56:15 -0000 1.1 +++ run.sh 24 Apr 2002 02:39:56 -0000 @@ -22,20 +22,18 @@ fi # Main.java has hard coded config values so this script must be run from -# altprofile/bin (any better ideas ?) -EXAMPLE_HOME=../.. +# instrument-manager/example (any better ideas ?) +EXAMPLE_HOME=.. # # Build the runtime classpath # -for i in ${EXAMPLE_HOME}/commonlib/*.jar ; do +for i in ${EXAMPLE_HOME}/lib/*.jar ; do CP=${CP}:$i done -CP=${CP}:../lib/altprofile.jar - #echo $CP # Run the example application -$JAVACMD -classpath $CP org.apache.avalon.examples.altprofile.Main $@ +$JAVACMD -classpath $CP org.apache.avalon.excalibur.instrument.example.Main $@
Index: instrument.xml =================================================================== RCS file: /home/cvspublic/jakarta-avalon-excalibur/instrument-manager/example/conf/instrument.xml,v retrieving revision 1.2 diff -u -r1.2 instrument.xml --- instrument.xml 29 Mar 2002 14:03:49 -0000 1.2 +++ instrument.xml 24 Apr 2002 02:40:58 -0000 @@ -39,19 +39,19 @@ <instrument name="random-quick" description="Random Values at a quick rate."> <sample type="maximum" interval="1000" size="600" description="Maximum each second."/> <sample type="minimum" interval="1000" size="600" description="Minimum each second."/> - <sample type="average" interval="1000" size="600" description="Average each second."/> + <sample type="mean" interval="1000" size="600" description="Average +each second."/> </instrument> <instrument name="random-slow" description="Random Values at a slow rate."> <sample type="maximum" interval="1000" size="600" description="Maximum each second."/> <sample type="minimum" interval="1000" size="600" description="Minimum each second."/> - <sample type="average" interval="1000" size="600" description="Average each second."/> + <sample type="mean" interval="1000" size="600" description="Average +each second."/> </instrument> <instrument name="random-random" description="Random Values at a random rate."> <sample type="maximum" interval="1000" size="600" description="Maximum each second."/> <sample type="minimum" interval="1000" size="600" description="Minimum each second."/> - <sample type="average" interval="1000" size="600" description="Average each second."/> + <sample type="mean" interval="1000" size="600" description="Average +each second."/> </instrument> <instrument name="counter-quick" description="Count of actions at a quick rate."> @@ -76,4 +76,4 @@ </instrument> </instrumentable> </instrumentables> -</instrument> \ No newline at end of file +</instrument>
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>