mcconnell 2003/02/04 22:26:53
Modified: src/java/org/apache/log Priority.java
src/java/org/apache/log/output NullOutputLogTarget.java
src/java/org/apache/log/output/net DatagramOutputTarget.java
SMTPOutputLogTarget.java
Log:
Checkstyle corrections and javadoc additions.
Revision Changes Path
1.16 +3 -0 jakarta-avalon-logkit/src/java/org/apache/log/Priority.java
Index: Priority.java
===================================================================
RCS file: /home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/Priority.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- Priority.java 3 Feb 2003 17:40:12 -0000 1.15
+++ Priority.java 5 Feb 2003 06:26:52 -0000 1.16
@@ -188,6 +188,7 @@
* Test whether this priority is greater than other priority.
*
* @param other the other Priority
+ * @return TRUE if the priority is greater else FALSE
*/
public boolean isGreater( final Priority other )
{
@@ -198,6 +199,7 @@
* Test whether this priority is lower than other priority.
*
* @param other the other Priority
+ * @return TRUE if the priority is lower else FALSE
*/
public boolean isLower( final Priority other )
{
@@ -208,6 +210,7 @@
* Test whether this priority is lower or equal to other priority.
*
* @param other the other Priority
+ * @return TRUE if the priority is lower or equal else FALSE
*/
public boolean isLowerOrEqual( final Priority other )
{
1.8 +4 -0
jakarta-avalon-logkit/src/java/org/apache/log/output/NullOutputLogTarget.java
Index: NullOutputLogTarget.java
===================================================================
RCS file:
/home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/output/NullOutputLogTarget.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- NullOutputLogTarget.java 3 Feb 2003 17:40:13 -0000 1.7
+++ NullOutputLogTarget.java 5 Feb 2003 06:26:52 -0000 1.8
@@ -57,11 +57,15 @@
/**
* A output target that does nothing. Useful for profiling.
*
+ * @author <a href="mailto:[EMAIL PROTECTED]";>Avalon Development
Team</a>
* @author <a href="mailto:[EMAIL PROTECTED]";>Peter Donald</a>
*/
public class NullOutputLogTarget
extends AbstractOutputTarget
{
+ /**
+ * Creation of a new null log target.
+ */
public NullOutputLogTarget()
{
open();
1.6 +2 -0
jakarta-avalon-logkit/src/java/org/apache/log/output/net/DatagramOutputTarget.java
Index: DatagramOutputTarget.java
===================================================================
RCS file:
/home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/output/net/DatagramOutputTarget.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- DatagramOutputTarget.java 3 Feb 2003 17:40:16 -0000 1.5
+++ DatagramOutputTarget.java 5 Feb 2003 06:26:52 -0000 1.6
@@ -65,6 +65,7 @@
* A datagram output target.
* Useful for writing using custom protocols or writing to syslog daemons.
*
+ * @author <a href="mailto:[EMAIL PROTECTED]";>Avalon Development
Team</a>
* @author <a href="mailto:[EMAIL PROTECTED]";>Peter Donald</a>
*/
public class DatagramOutputTarget
@@ -78,6 +79,7 @@
*
* @param address the address endpoint
* @param port the address port
+ * @param formatter the formatter
* @exception IOException if an error occurs
*/
public DatagramOutputTarget( final InetAddress address,
1.4 +5 -4
jakarta-avalon-logkit/src/java/org/apache/log/output/net/SMTPOutputLogTarget.java
Index: SMTPOutputLogTarget.java
===================================================================
RCS file:
/home/cvs/jakarta-avalon-logkit/src/java/org/apache/log/output/net/SMTPOutputLogTarget.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- SMTPOutputLogTarget.java 3 Feb 2003 17:40:16 -0000 1.3
+++ SMTPOutputLogTarget.java 5 Feb 2003 06:26:52 -0000 1.4
@@ -60,7 +60,6 @@
import javax.mail.MessagingException;
import javax.mail.Session;
import javax.mail.Transport;
-import javax.mail.internet.InternetAddress;
import javax.mail.internet.MimeMessage;
import org.apache.log.format.Formatter;
import org.apache.log.output.AbstractOutputTarget;
@@ -68,6 +67,7 @@
/**
* Logkit output target that logs data via SMTP (ie. email, email gateways).
*
+ * @author <a href="mailto:[EMAIL PROTECTED]";>Avalon Development
Team</a>
* @author <a href="mailto:[EMAIL PROTECTED]";>Marcus Crafter</a>
* @version CVS $Id$
* @since 1.1.0
@@ -115,8 +115,7 @@
final Address fromAddress,
final String subject,
final int maxMsgSize,
- final Formatter formatter
- )
+ final Formatter formatter )
{
super( formatter );
@@ -162,7 +161,9 @@
// send mail if message size has reached it's size limit
if ( m_msgSize >= m_maxMsgSize )
+ {
send();
+ }
}
catch ( MessagingException e )
{
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
