Seems like this is already decided. However you have removed the ability to change the listener. At least add that back.
Fairly silly if you ask me but I got not choice in the manner. The listener is an abstract class not an interface and is not likely to be ever multicast. Just as a curious question - does anyone actually know what use case would use multicast? Or is this just flexability syndrome? On Thu, 6 Feb 2003 16:37, Berin Loritsch wrote: > We got sidetracked on this issue. LogKit 1.2rc5 works with no bugs > reported. > > The only outstanding issue before a release is the LoggerListener API. > > > Do we define the LoggerListener registration as: > > //------------------------------------------------------------------ > void setLoggerListener( final LoggerListener loggerListener ) > { > m_loggerListener = loggerListener; > } > //------------------------------------------------------------------ > * Easy, and already done. > * Can be overridden at any time, losing the old listener > * Possible change in API requiring deprecation if we decide to enable > multicasting. > > > Or do we define it as: > > //------------------------------------------------------------------ > void addLoggerListener( final LoggerListener listener ) > throws java.util.TooManyListenersException() > { > if ( null == m_loggerListener ) > { > m_loggerListener = listener; > } > else > { > throw new java.util.TooManyListenersException(); > } > } > //------------------------------------------------------------------ > * Easy to do, does not change functionality > * Clearer contract, although it forces client code to do exception > handling for the listener. > * No future API changes other than the removal of the declared exception > > > I don't care which one we decide on as long as we decide soon. I want > to get the release out the door. Now is not the time to discuss the > technical merits of either approach, just put down your preference. > > I am +0 on setLoggerListener and -0 on addLoggerListener > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] -- Cheers, Peter Donald ------------------------------------------------------ Mark Twain: "In the real world, the right thing never happens in the right place at the right time. It is the task of journalists and historians to rectify this error." ------------------------------------------------------ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]