On Fri, 31 Aug 2001 13:52, Mircea Toma wrote:
> Hi,
>
> Here is the TextMessageBuilder changed accordingly to our discussion.
> I also created a FormattedTextMessageBuilder to replace the
> XMLMessageBuilder, the type of Formatter is passed in the contructor.
>
> ..... and, yes I finished the JMSQueueTarget that should be used in the
> JMSTargetFactory (one factory per media).

Looks good. I committed it as-is but theres a few things I am not sure about. 
Is there a need for ContentInfo ? I couldn't see any real-life reason for it 
to be honest. Removing it would decrease complexity I think.

For the odd cases that may need that style functionality we could instead 
replace it with a Formatter. Thus we would have something like

protected String getText( LogEvent event )
{
  if( null != m_formatter )
  { 
     m_formatter.format( event );
  }
  else
  {
    return event.getMessage();
  }
}

In theory we could also replace FormattedTextMessageBuilder with extra 
constructor that sets m_properties = new PropertyInfo[ 0 ];

Thoughts??

-- 
Cheers,

Pete

---------------------------------------------------------------
The difference between genius, and stupidity? Genius has limits
---------------------------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to