Re: Is everyone happy with Namespace?

[Sylvain Wallez]

Berin Loritsch a écrit :
> 
> I want to clarify if everyone is happy with the Namespace
> class.  We need to take care of it NOW before it is too
> late!

Namespace info and Configuration names are OK for me, but a few
questions about the prefix validation in Namespace.equals() :

- Namespace.m_policy doesn't seem to be used. Shouldn't it be used in
Namespace.getNamespace() ? Otherwise m_validate_prefix is always true.

- is this good to have a static setting for this policy in a
multi-thread/multi-app environment ?


Here's also a patch for exception messages : Peter removed ','
characters from the patch I sent recently, but also removed the closing
'"' for element names ! This patch adds them, but not the ',' !

Thanks,
Sylvain.

-- 
Sylvain Wallez
Anyware Technologies - http://www.anyware-tech.com
? config-msg.txt
Index: AbstractConfiguration.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-avalon/src/java/org/apache/avalon/framework/configuration/AbstractConfiguration.java,v
retrieving revision 1.7
diff -u -r1.7 AbstractConfiguration.java
--- AbstractConfiguration.java  2001/11/01 21:04:47     1.7
+++ AbstractConfiguration.java  2001/11/09 13:50:03
@@ -56,7 +56,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as an integer in the 
configuration element \"" +
-                                              getName() + " at " + 
getLocation() );
+                                              getName() + "\" at " + 
getLocation() );
         }
     }
 
@@ -117,7 +117,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as a long in the 
configuration element \"" +
-                                              getName() + " at " + 
getLocation() );
+                                              getName() + "\" at " + 
getLocation() );
         }
     }
 
@@ -160,7 +160,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as a float in the 
configuration element \"" +
-                                              getName() + " at " + 
getLocation() );
+                                              getName() + "\" at " + 
getLocation() );
         }
     }
 
@@ -204,7 +204,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as a boolean in the 
configuration element \"" +
-                                              getName() + " at " + 
getLocation() );
+                                              getName() + "\" at " + 
getLocation() );
         }
     }
 
@@ -282,7 +282,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as an integer in the 
attribute \"" + 
-                                              name + " at " + getLocation() );
+                                              name + "\" at " + getLocation() 
);
         }
     }
 
@@ -348,7 +348,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as a long in the attribute 
\"" + 
-                                              name + " at " + getLocation() );
+                                              name + "\" at " + getLocation() 
);
         }
     }
 
@@ -395,7 +395,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as a float in the attribute 
\"" + 
-                                              name + " at " + getLocation() );
+                                              name + "\" at " + getLocation() 
);
         }
     }
 
@@ -444,7 +444,7 @@
         {
             throw new ConfigurationException( "Cannot parse the value \"" + 
value +
                                               "\" as a boolean in the 
attribute \"" + 
-                                              name + " at " + getLocation() );
+                                              name + "\" at " + getLocation() 
);
         }
     }
 
Index: DefaultConfiguration.java
===================================================================
RCS file: 
/home/cvspublic/jakarta-avalon/src/java/org/apache/avalon/framework/configuration/DefaultConfiguration.java,v
retrieving revision 1.7
diff -u -r1.7 DefaultConfiguration.java
--- DefaultConfiguration.java   2001/11/01 09:13:56     1.7
+++ DefaultConfiguration.java   2001/11/09 13:50:04
@@ -90,7 +90,7 @@
         {
             throw new ConfigurationException( "No value is associated with the 
"+
                                               "configuration element \"" + 
getName() +
-                                              " at " + getLocation() );
+                                              "\" at " + getLocation() );
         }
     }
 
@@ -147,7 +147,7 @@
         {
             throw new ConfigurationException( "No attribute named \"" + name + 
"\" is " +
                                               "associated with the 
configuration element \"" +
-                                              getName() + " at " + 
getLocation() );
+                                              getName() + "\" at " + 
getLocation() );
         }
     }
 


--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>