Looks good. Theres a few reservations I have which I will go through on Sunday. Hopefully after they are resolve I will apply your changes.
Thanks! On Fri, 23 Aug 2002 05:06, Igor Fedorenko wrote: > I have a patch that I am reasonably happy with. It adds support for > block invocation interceptors in a form > > <block name="block-name" class="tes.TestBlock"> > <proxy> > <interceptor class="test.TestInterceptor"/> > </proxy> > </block> > > It also adds support for block factories. In assemble.xml > > <factory name="test-factory" class="test.Factory"/> > <block name="block-name" > factory="test-factory" impl="factory-specific-impl"/> > > Old block definition is supported as well. > > There is a number of outstanding @todo items but most of them are of > cosmetic nature (proper package names, proper exception classes and > missing javadoc). One real issue is configuration of loggers for block > factories -- now logs go into assembler's logger. > > Could somebody who is in charge review the patch and comment on whether > it will or will not be incorporated into the source code? Thank you. > > Peter Donald wrote: > > On Tue, 20 Aug 2002 23:13, Igor Fedorenko wrote: > >>Peter Donald wrote: > >>>On Tue, 20 Aug 2002 00:59, Igor Fedorenko wrote: > >>>>Not exactly. Soap does not have to be java, so getting "all remote > >>>>interfaces" of none-java service would be tricky. Of course, one could > >>>>write a factory that is smart enough to map soap urls into java > >>>>interfaces, but this sounds like hiding problems instead of solving > >>>> them. > >>> > >>>If that is the case you could still use the same interface with a slight > >>>modification > >>> > >>><block name="my-block-remote" > >>> impl="resource:/my/soap/descriptor.xml" > >>> factory="org.apache.avalon.factorys.SoapFactory"> > >>></block> > >> > >>In fact, I cheat here -- encode service definition into "impl". > >> > >>So, lets say you've almost ;-) convinced me. I am going to implement > >>this as well as invocation interceptors and will post a patch sometime > >>later this week. > > > > kool! -- Cheers, Peter Donald ------------------------------------------------------------- | Egoism is the drug that soothes the pain of stupidity. | ------------------------------------------------------------- -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
