Review: Needs Fixing code review
Algunas cosas que cambiar.
Diff comments:
> === modified file 'dos_fix_contracts_price_unit/wizard/fix_price_view.xml'
> --- dos_fix_contracts_price_unit/wizard/fix_price_view.xml 2014-06-17
> 07:48:14 +0000
> +++ dos_fix_contracts_price_unit/wizard/fix_price_view.xml 2014-07-09
> 10:12:27 +0000
> @@ -6,24 +6,19 @@
> <field name="name">Fix Contract Price</field>
> <field name="model">fix.price</field>
> <field name="arch" type="xml">
> - <form string="Fix Contract Price">
> - <newline />
> + <form string="Fix Contract Price" version="7.0">
> <group colspan="4" col="4" states="choose">
Puedes quitar colspan="4" col="4", ya que es redundante en v7
> <field name="partner"
> domain="[('customer','=',True)]"
> colspan="4" />
> - <newline />
> <field name="elevator"
> domain="[('tipo_cliente','=','ascensorista')]"
> colspan="4" />
> - <newline />
> <field name="contract" colspan="4" />
> - <newline />
> <field name="contract_type" colspan="4" />
> - <newline />
> <field name="value" />
> <field name="percent" />
> <field invisible="1" name="state" />
> - <label colspan="4" />
> + <label colspan="4" string=""/>
Quita esta línea y la siguiente, ya que no sirve para nada. Supongo que la
tendrían como "espaciador".
> <separator colspan="4" />
> </group>
>
> @@ -32,27 +27,27 @@
> string="Process completed with exit" />
> <label colspan="4"
> string="If you want repeat this process, push Go
> Back button." />
> - <label colspan="4" />
> + <label colspan="4" string=""/>
Ídem
> <label colspan="4"
> string="If you finish, push Close button." />
Lo que puedes hacer es poner \n para establecer nuevas líneas aquí, o bien
poner version="7.0" y poner un <p> con el párrafo. Casi mejor esta segunda
opción, pero habrá que tocar traducción.
> - <label colspan="4" />
> + <label colspan="4" string=""/>
Eliminar
> <separator colspan="4" />
> </group>
> -
> - <group colspan="4" col="4" states="choose">
> - <button special="cancel" string="Cancel"
> - icon="gtk-cancel" />
> - <button name="fix_contract_price" string="Fix price"
> - type="object" icon="gtk-ok"
> - context="{'partner':partner, 'elevator':
> elevator, 'contract':contract, 'contract_type': contract_type, 'value':
> value, 'percent': percent}" />
> - </group>
> -
> - <group colspan="4" col="4" states="get">
> - <button name="go_back" string="Go back"
> - type="object" icon="" />
> - <button special="cancel" string="Close"
> - icon="gtk-cancel" />
> - </group>
> + <footer>
> + <group colspan="4" col="4" states="choose">
> + <button name="fix_contract_price" string="Fix
> price"
> + type="object" icon="gtk-ok"
> + context="{'partner':partner, 'elevator':
> elevator, 'contract':contract, 'contract_type': contract_type, 'value':
> value, 'percent': percent}" />
> + <button special="cancel" string="Cancel"
Poner class="oe_link" y la palabra "or"
> + icon="gtk-cancel" />
> + </group>
> + <group colspan="4" col="4" states="get">
> + <button name="go_back" string="Go back"
> + type="object" icon="" />
> + <button special="cancel" string="Close"
Poner class="oe_link"
> + icon="gtk-cancel" />
> + </group>
> + </footer>
> </form>
> </field>
> </record>
>
--
https://code.launchpad.net/~avanzosc-security-team/avanzosc/72h_dos_fix_contracts_price_unit/+merge/226091
Your team Avanzosc_security is subscribed to branch
lp:~avanzosc-security-team/avanzosc/72horas.
--
Mailing list: https://launchpad.net/~avanzosc
Post to : [email protected]
Unsubscribe : https://launchpad.net/~avanzosc
More help : https://help.launchpad.net/ListHelp
