Hello Manuel,
Sunday, July 01, 2001, 1:22:24 PM, you wrote:
MM> On 2001.07.01 12:26 Manuel McLure wrote:
>> I found the following issue when trying to compile CVS avi-xmms with CVS
>> avifile. In avifile's default.h the following construct is found:
>>
>> #ifdef HAVE_STDINT_H
>> #include <stdint.h> // for int64_t (on linux)
>> #else
>> #ifdef HAVE_SYS_TYPES_H
>> #include <sys/types.h> // for int64_t (on xBSD/solaris)
>> #endif
>> #endif
MM> [SNIP]
MM> With Mathew Kanner's help I have determined that in this specific case, we
MM> can simply use
MM> #include <inttypes.h>
MM> and this will work for Linux, Solaris and xBSD. I don't know whether this
MM> will work for Win32 - anyone want to test this?
There's no inttypes.h in MSVC++, but we don't care because
at the moment library is not supposed to compile on Win32.
MM> In further researching this I found that we are also doing a
MM> #include <config.h>
MM> in default.h. If the config.h that we are including is the one from
MM> avifile, then the problem above would not happen. However the syntax we use
MM> does not specify what config.h to use, so we may be picking up the
MM> third-party's config.h instead of the avifile one. We could use
MM> #include <avifile/config.h>
MM> instead to make sure we are including the right one (and maybe even change
MM> all #includes that correspond to avifile headers to use this syntax thus
MM> avoiding namespace pollution). This will work for third-party software,
MM> however it won't work for building avifile unless we make some changes to
MM> the avifile build process (create an include/avifile directory and copy any
MM> .h files into it before building).
I believe that generally it is a third-party programmer responsibility to
make a check for stdint.h. In this particular case I'll replace the
construction. Do we have any more problematic places in headers?
--
Best regards,
Eugene
mailto:[EMAIL PROTECTED] or [EMAIL PROTECTED]
[Team GADGET] [Team Two Divided By Zero]
_______________________________________________
Avifile mailing list
[EMAIL PROTECTED]
http://prak.org/mailman/listinfo/avifile
