Hi, > > I've just finished removing unneeded dependency on c++ headers of the > > directshow code. The only 'deep' change to reach it was changing type of > > CodecInfo:dll from string to char*. > > we will just replace std:: with avm:: > and it will have same compilation speed and we do not have to care about > memory allocation deallocation - as I've already told you this is on > going change... > > (avm::string is basicaly char* - except we do not have to call free) > (guess why default.h contains this line: //#define std avm )
Hey man, why do you need free() there at all? The caller program (aviplay/mplayer) pass a char* pointer to DSHow decoder constructor in order to open the codec. The _caller_ must worry about free()ing its string, not the dll loader / directshow interface lib!!! I still don't understand what is that char* -> string -> char* good for... (except that it shows the power of C++ :)) > > It would be great if you sync avifile CVS with my changes. > > (note: DS_VideoDecoder.cpp not yet synced with your autoquality changes) > > I've thought I'll receive patch I think it's simpler for you check diff between mplayer and avifile tree, and update avifile if needed. Of course I can generate the patch for you if you can't/don't want... > > Except driver.c, vfw.c and afl.c, but they aren't used by avifile. > > I think they are used - except in very unusual conditions - but ACM > audio driver is definitely using them. Hmm, really. acmStreamOpen is called from outside, and it goes to driver.c How do you handle the codec DLL filename then? Are you using the hardcodec names in driver.c ? It's very bad then... A'rpi / Astral & ESP-team -- mailto:[EMAIL PROTECTED] http://esp-team.scene.hu _______________________________________________ Avifile mailing list [EMAIL PROTECTED] http://prak.org/mailman/listinfo/avifile
