Am 22.03.2011 23:41, schrieb David Lonie:
> Hi Carsten,
>
> On Tue, Mar 22, 2011 at 3:27 PM, Carsten Niehaus<[email protected]> wrote:
>> As soon as you have a windows-binary for me to test I will test your code
>> and report back.
>
> I've built and uploaded a window installer here:
>
> http://avogadro.openmolecules.net/nightly/win/crystallography-preview/Avogadro-1.1.0-win32.exe
>
> Dave
Works.
Comments:
* I'd add some tooltips
* I get a crash (read-error) when exiting Avogadro (Windows XP). I have
no idea how to get a backtrace in Windows.
* You already said that you want to integrate the two other
crystallography tools. Especially the "Super Cell Builder" belongs into
your dockwidget
* cannot select nm for the lenght (only angstrom and bohr).
* No matter which spacegroup I set I see no difference beside the
debug-message changing in the top left corner.
* I think that you shouldn't use a this QComboBox for those spacegroups
("Set Spacegroup"-menu). Right now it looks like this:
1: P 1
2: P -1
3: P 1 2 1
I don't like two things about this: First, in the UI it then reads P 1
(1), IMHO it should also be 1: P 1 (consistency). Second: Why don't you
write
Cubic: P 1
Cubic: P -1
Cubic: P 1 2 1
Orthorombic: ...
Perhaps you could even add a second QComboBox with Triclinic, monoclic,
Orthorombic etc and then remove all other groups from the second
combobox. That would make the list *way* shorter. Perhaps its just me
but I find that list not exactly easy to parse :-)
Carsten
------------------------------------------------------------------------------
Enable your software for Intel(R) Active Management Technology to meet the
growing manageability and security demands of your customers. Businesses
are taking advantage of Intel(R) vPro (TM) technology - will your software
be a part of the solution? Download the Intel(R) Manageability Checker
today! http://p.sf.net/sfu/intel-dev2devmar
_______________________________________________
Avogadro-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/avogadro-devel
