On Tue, Feb 4, 2014 at 5:39 AM, Jure Varlec <[email protected]> wrote: >> > Also, I had to add an include path for Eigen to fix building, do I have >> > to make a separate branch for that single commit? >> I'm not sure why that (adding an Eigen include path) would be necessary. >> That should be covered by CMake. Why don't you comment on your problems >> with Eigen and we'll see if it can be fixed outside of a patch. > > Well, CMake finds both Eigen2 and Eigen3, but build fails with 'fatal error: > Eigen/Core: No such file or directory' unless I patch it with > > diff --git a/libavogadro/src/colors/CMakeLists.txt > b/libavogadro/src/colors/CMakeLists.txt > index a967516..c0836a8 100644 > --- a/libavogadro/src/colors/CMakeLists.txt > +++ b/libavogadro/src/colors/CMakeLists.txt > @@ -6,7 +6,7 @@ ADD_DEFINITIONS(-DQT_SHARED) > > set(DESTINATION_DIR ${Avogadro_PLUGIN_INSTALL_DIR}/colors) > > -include_directories(${CMAKE_CURRENT_BINARY_DIR}) > +include_directories(${CMAKE_CURRENT_BINARY_DIR} ${EIGEN_INCLUDE_DIR}) > > set(LINK_LIBS avogadro) > set(PLUGIN_LABEL colors)
Are you building with Eigen 2 or 3? I just looked at master, and libavogadro/src/CMakeLists.txt adds it to the include directories, the same is not true for Eigen 3. There are still a number of rough edges with the Eigen 3 support, we should take a pass at getting that to build consistently. A lot of people (myself included) have Eigen installed and can miss this. I also don't see anything that defines EIGEN_INCLUDE_DIR, both variants have the major version number. Hope that helps. Marcus ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Avogadro-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/avogadro-devel
