So removing VLA for detection only might not be too much work.
Basically you’d need to remove subspace.c and character_table.c, and anything 
calling those functions.
You’d also need to remove the parts of linalg that does variable size matrix 
operations (som parts of linalg.c should really be replaced with lapac/blas 
calls).

There is also code like this:
int *array = malloc(sizeof(int[l]));

which is just me being stupid and should be replaced with:
int *array = malloc(l*sizeof(*array)) or
int *array = calloc(l,sizeof(*array))

(required for more compilers than just VC, but I haven’t got the time)

PS

The latest checkin is quite a significant improvement on detection for 
symmetric polyhedra.

/M

On 27 May 2016, at 17:21, Marcus D. Hanwell <[email protected]> wrote:

> On Fri, May 27, 2016 at 10:27 AM, Geoffrey Hutchison
> <[email protected]> wrote:
>>> How would you like to compile libmsym with clang for Windows?
>> 
>> It works, but it just makes the builds a bit tricky (i.e., if you're 
>> building Avogadro, you need clang for Windows + Visual Studio + .. etc.)
>> 
>> I guess if we had a pre-built DLL for libmsym that people can download and 
>> use in an Avogadro-on-Windows build, that could work.
>> 
>> I'm definitely open to suggestions - while the symmetry features clearly 
>> need more development, it's quite nice to be able to symmetrize something to 
>> D4h.
> 
> I would prefer to have a simpler option for compiling Avogadro, if
> that is without symmetry I think that is OK. Turning something on for
> those who want to set up a more complex build environment seems fair
> enough though.
> 
> Marcus
> 
> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are 
> consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
> J-Flow, sFlow and other flows. Make informed decisions using capacity 
> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> _______________________________________________
> Avogadro-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/avogadro-devel


------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://sdm.link/zohomanageengine
_______________________________________________
Avogadro-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/avogadro-devel

Reply via email to