On Thu, May 17, 2012 at 4:22 PM, Geoffrey Hutchison <geo...@pitt.edu> wrote: >> Some feedback; it's a nice read: > > Drat. Now I can't use you as a reviewer. ;-)
:) >> - in the reference section, many of the cited webpage do not author(s) >> yet. Those should be added. E.g. "55. OpenSMILES 2012, >> [http://opensmiles.org/]."; This is a specification, much more than a >> random webpage. BMC allows authors on webpages, and is the right thing >> to do. > > It's a good idea. I'll have to look through all contributors to the > specification. It applies to several webpage / references... >> - in section 5 you should explain why Avogadro stuck with GPL, when Qt >> moved to LGPL, because the text now seems to suggest the latter is >> better and you were forced into GPL when Qt still had that license. > > Good point. As you're aware, the restriction is on Open Babel. This is one > incentive for the MolCore and ChemKit pushes, and I think it's fair to state > that Avogadro 2.0 will be released under the BSD license. OK. I thoughts so, but the next did not say much about strong dependencies in that part... But nothing wrong with clarifying such things in the paper, IMHO. >> aspect is of OpenGL... there are plenty of *new* but crappy ThinkPads >> around which only have a mobile graphics processor. I have one, and it >> really sucks, and makes Avogadro very slow on my laptop (surfaces are >> impossible, but even default rotation is awkward…). > > I appreciate your suggestions here, but I'm curious about your performance > issues. As you know, I use Mac, and many of my students use Windows. My group > has several of these "slow" integrated GPUs and have good performance. I know > you're using Linux, but what driver are you using? Fair point, indeed. It's running 'i915'... that's kind of something I miss in Debian GNU/Linux... clear suggestions on what less free but better performing modules I can use. >> - and to balance things, OpenGL also makes Avagadro more crash-prone >> (and fairly, with just 2 minutes of working with it, it crashed again, >> though I could not reproduce it in the next 2 minutes) > > One issue we've identified with OpenGL is the existence of different > "pipelines." Most of the tutorials out there for OpenGL, and indeed many > other viewer programs use an older pipeline, rather than uploading shapes > onto the GPU. The latter strategy is used by modern games. So better > performance is found in this modern pipeline, and this aspect of the card and > driver are more heavily tested. > > But is this Avogadro's crash because the driver has a bug? I'm happy to look > at crash logs and stack traces, but 90% of these "random" crashes turn out to > be the drafting. Dunno, unfortunately :( The command line only said 'Segmentation fault'... how do I turn on debugging? >> - fig 10: explain the coloring in the caption >> - "Other requirements (if compiling): CMake 2.6+" Should Qt, OB, ... >> not be listed here too? > > Good points. > >> - "Any restrictions to use by non-academics: None" That's a BMC thing, >> but obviously non-academics do have restrictions too: they are equally >> copy-lefted like anyone else :) > > Do you have a suggestion for wording? This is something I should pick up with Kuras and Bailey... "None additional" or "No specific"? >> What about a scripting language, like Jmol and Bioclipse have? > > You can script Avogadro using Python. I'm investigating use of JavaScript > through QtScript, but there are cases of Python extensions -- it's probably > worth us linking to a few of these. Yeah, I saw the Python binding... but I could not find how to use that via the GUI... if that is possible, then I would certainly mention that in the paper. Egon -- Dr E.L. Willighagen Postdoctoral Researcher Department of Bioinformatics - BiGCaT Maastricht University (http://www.bigcat.unimaas.nl/) Homepage: http://egonw.github.com/ LinkedIn: http://se.linkedin.com/in/egonw Blog: http://chem-bla-ics.blogspot.com/ PubList: http://www.citeulike.org/user/egonw/tag/papers ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Avogadro-Discuss mailing list Avogadro-Discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/avogadro-discuss
