URL:
<http://savannah.nongnu.org/patch/?9553>
Summary: Fix some issues in libc/
Project: AVR C Runtime Library
Submitted by: gjlayde
Submitted on: Wed 24 Jan 2018 04:01:56 PM UTC
Category: None
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
This patch fixes some build warnings and a potential wrong-code issues in
GETBYTE as used by vfprintf and vfscanf:
Inline asm operand %0 might override operand %2 as the compiler may assign the
same hard register to either operands. Hence, %0 needs an early-clobber
constraint so that setting %0 will never set %2 (%2 is used after the first
set of %0). Presumably, this has never led to a problem because %2 is used in
a loop and is not dead after the asm, yet it is a potential bug.
* libc/stdio/vfscanf.c (GETBYTE) [LPMx]: Early-clobber %0.
(GETBYTE) [default]: Use shorter instruction sequence.
* libc/stdio/vfprintf.c: Same.
(vfprintf): Fix build-warnings.
* libc/stdlib/dtostre.c (dtostre): Fix build warning.
* libc/stdlib/getenv.c (getenv): Fix build warning.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Wed 24 Jan 2018 04:01:56 PM UTC Name: avrlibc-libc.diff Size: 2KiB
By: gjlayde
patch
<http://savannah.nongnu.org/patch/download.php?file_id=43066>
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?9553>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
_______________________________________________
AVR-libc-dev mailing list
AVR-libc-dev@nongnu.org
https://lists.nongnu.org/mailman/listinfo/avr-libc-dev
