On Wed, 15 Jun 2011, Alexey Pavluchenko wrote: > Hello all,
Alexey, Thank you for testing the newest version! I still don't have enough code to do more testing, so your input is more than valued. > == cut == > > The "missing prototype" one is easy to fix: the declaration of list_devices > in device.h should be changed to "void list_devices(void)". (fix commited to git) > The second warning is related to the dataset structure which is referenced in > several places as "const struct dataset const *foo". I can't really figure > out what this declaration is supposed to mean, but my guess is that the first > "const" declares every field of the structure unassignable, while the second > "const" declares the referenced structure itself unassignable, is that right? > Shouldn't a single "const" be sufficient in this case? (fix commited to git) Yes, that was my overzealous const correctness, thanks for pointing out. "const char * const dset_name" means "immutable pointer and immutable values pointed by the pointer" and this is a proper way of indicating this - and this is now accepted by lcc as well. I have managed to run lcc under wine on my FreeBSD box so I can catch more errors. It seems like gcc and clang (with -Wall) are not enough. I will have a look at the .DEF problem as well, I think the code can be simplified a bit there and we also need to have a working .UNDEF //Marcin ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ Avra-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/avra-user
