On Tuesday 18 April 2006 18:32, Joerg Wunsch wrote:
> As Julius Luukko wrote:
> > Jörg's patch for inverting parallel port pins makes it possible to
> > use ere's (www.ere.co.th) programmer AVR-ISP with avrdude. ...
>
> Thanks, committed!
Hello,
I noticed that a semicolon is missing from the desc-line. My mistake - my
submission didn't have it either.
Another matter is that the exitspec handling must also take the inversion of
RESET into account. Here's a patch (against par.c revision 1.15) for a
possible correction. It works at least with my ere-isp-avr.
--
Julius
--- avrdude/par.c 2006-04-13 23:10:55.000000000 +0300
+++ avrdude-new/par.c 2006-04-20 22:41:30.000000000 +0300
@@ -357,10 +357,16 @@
while ((cp = strtok(s, ","))) {
if (strcmp(cp, "reset") == 0) {
- *clr |= par_getpinmask(pgm->pinno[PIN_AVR_RESET]);
+ if (pgm->pinno[PIN_AVR_RESET] & PIN_INVERSE)
+ *set |= par_getpinmask(pgm->pinno[PIN_AVR_RESET]);
+ else
+ *clr |= par_getpinmask(pgm->pinno[PIN_AVR_RESET]);
}
else if (strcmp(cp, "noreset") == 0) {
- *set |= par_getpinmask(pgm->pinno[PIN_AVR_RESET]);
+ if (pgm->pinno[PIN_AVR_RESET] & PIN_INVERSE)
+ *clr |= par_getpinmask(pgm->pinno[PIN_AVR_RESET]);
+ else
+ *set |= par_getpinmask(pgm->pinno[PIN_AVR_RESET]);
}
else if (strcmp(cp, "vcc") == 0) {
if (pgm->pinno[PPI_AVR_VCC])
_______________________________________________
avrdude-dev mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/avrdude-dev
