Hi Joerg, Is there anyway that your email could make it into the documentation somewhere? I'm afraid I'll lose track of the email if, and when, I finally get around to doing any commits in the future.
Thanks, Eric > -----Original Message----- > From: > avrdude-dev-bounces+eric.weddington=atmel....@nongnu.org > [mailto:avrdude-dev-bounces+eric.weddington=atmel....@nongnu.o > rg] On Behalf Of Joerg Wunsch > Sent: Thursday, January 07, 2010 6:44 AM > To: avrdude-dev@nongnu.org > Subject: [avrdude-dev] To all committers: some stylistic things > > Thanks to everybody for improving the AVRDUDE code base. I see > there were a number of commits within the past months. > > I'm not very religious about stylistic issues. After all, I basically > "inherited" the maintenance of that project from Brian Dean, and a lot > of the code present in AVRDUDE today has been contributed by a large > number of people in the past, so the overall style is not very > uniform. Just a few things I'm asking for. > > . For new files, please take care to have at least the svn:eol-style > set to "native", and svn:keywords to (at least) "Id". Add $Id$ > lines to each file so the file's version can be tracked "in the > field". Preferrably, do also set svn:mime-type (usually to > text/plain). The easiest way to do this is to activate the line > > enable-auto-props = yes > > in your ~/.subversion/config file (or wherever this file lives in > your environment), and add suitable auto-props patterns. For > reference, I'm appending the patterns I've been collecting in my SVN > era so far below. > > . If possible, avoid non-ASCII characters (there have been a few UTF-8 > long dashes in some file, where simple ASCII dashes would do fine). > > . When using hard TABs, the remainder of the AVRDUDE code uses them > with a tab stop each 8 columns, as is the historical DEC VTxx (and > Unix) standard. If you don't like this, then better don't use TABs > but simple spaces everywhere. > > . Try avoiding trailing white space behind the printable characters of > each line (even though the historic AVRDUDE code suffers a lot from > that still, and I hesitate to force commits for code that has > otherwise not been touched sometimes for years). > > Thanks again for all your contributions! > > [auto-props] > Makefile* = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.1 = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.a = svn:mime-type=application/octet-stream > *.am = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.aps = > svn:mime-type=text/plain;svn:eol-style=CRLF;svn:keywords="Auth > or Id Date" > *.asm = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.bat = > svn:mime-type=text/plain;svn:eol-style=CRLF;svn:keywords="Auth > or Id Date" > *.bpl = svn:mime-type=application/octet-stream > *.c = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.cdr = svn:mime-type=application/octet-stream > *.cfg = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.cmake = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.cpp = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.css = > svn:mime-type=text/xml;svn:eol-style=native;svn:keywords="Auth > or Id Date" > *.csv = svn:mime-type=text/csv;svn:eol-style=native > *.cvsignore = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.ddp = svn:mime-type=application/octet-stream > *.de = svn:mime-type=application/octet-stream > *.dep = svn:mime-type=application/xml > *.dfm = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.diff = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.dll = svn:mime-type=application/octet-stream > *.doc = svn:mime-type=application/msword > *.dot = svn:mime-type=application/msword > *.dox = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.gif = svn:mime-type=image/gif > *.eps = > svn:mime-type=application/postscript;svn:eol-style=native;svn: > keywords="Author Id Date" > *.ewd = svn:mime-type=application/xml > *.ewp = svn:mime-type=application/xml > *.eww = svn:mime-type=application/xml > *.exe = svn:mime-type=application/octet-stream > *.gz = svn:mime-type=application/octet-stream > *.h = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.hex = svn:mime-type=text/plain;svn:eol-style=CRLF > *.html = > svn:mime-type=text/html;svn:eol-style=native;svn:keywords="Aut > hor Id Date" > *.i = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.in = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.inc = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.info = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.jpg = svn:mime-type=image/jpeg > *.js = > svn:mime-type=text/javascript;svn:eol-style=native;svn:keyword > s="Author Id Date" > *.kdevelop = > svn:mime-type=text/xml;svn:eol-style=native;svn:keywords="Auth > or Id Date" > *.l = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.local = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.mk = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.mpp = svn:mime-type=application/vnd.ms-project > *.odg = svn:mime-type=application/octet-stream > *.odp = svn:mime-type=application/octet-stream > *.patch = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.pdf = svn:mime-type=application/pdf > *.pl = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.png = svn:mime-type=image/png > *.ppt = svn:mime-type=application/vnd.ms-powerpoint > *.py = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.s = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.scons = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.sh = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date";svn:executable > *.sty = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.sxc = svn:mime-type=application/octet-stream > *.sxw = svn:mime-type=application/octet-stream > *.tc = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.tex = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.ts = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.txt = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > *.ui = svn:mime-type=application/xml > *.vdx = svn:mime-type=application/xml > *.vsd = svn:mime-type=application/visio > *.vsx = svn:mime-type=application/xml > *.wmf = svn:mime-type=application/octet-stream > *.wxg = svn:mime-type=application/xml > *.xcl = > svn:mime-type=text/plain;svn:eol-style=CRLF;svn:keywords="Auth > or Id Date" > *.xls = svn:mime-type=application/vnd.ms-excel > *.xml = > svn:mime-type=text/xml;svn:eol-style=native;svn:keywords="Auth > or Id Date" > *.xsd = > svn:mime-type=text/xml;svn:eol-style=native;svn:keywords="Auth > or Id Date" > *.xsl = > svn:mime-type=text/xml;svn:eol-style=native;svn:keywords="Auth > or Id Date" > *.y = > svn:mime-type=text/plain;svn:eol-style=native;svn:keywords="Au > thor Id Date" > > -- > cheers, J"org .-.-. --... ...-- -.. . DL8DTL > > http://www.sax.de/~joerg/ NIC: JW11-RIPE > Never trust an operating system you don't have sources for. ;-) > > > _______________________________________________ > avrdude-dev mailing list > avrdude-dev@nongnu.org > http://lists.nongnu.org/mailman/listinfo/avrdude-dev > _______________________________________________ avrdude-dev mailing list avrdude-dev@nongnu.org http://lists.nongnu.org/mailman/listinfo/avrdude-dev