[
https://issues.apache.org/jira/browse/AVRO-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705742#action_12705742
]
Konstantin Boudnik commented on AVRO-26:
----------------------------------------
Thanks for the comments, Doug.
Couple of replies:
- TestProtocol kinda imply that other TestProtocol* classes are in a
sort of relation with this one, which I believe isn't true. So I went
with Simple
- agree, this is an artifact of my own environment where testng was
placed separately. Fixed. It sounds like a good idea to move test
related libs to src/test/lib. And the version part has to be stripped.
However, if Avro will move toward Ivy it will be changed anyways, right?
Also, it seems that junit-4.5.jar sits in the lib directory as well :-)
- done, sorry I've missed this piece of original functionality
- looks like testdefs are needed in every target in case someone will
have to run test-interop-data-java. If testng isn't define within that
target then the testing will fail
- test-reports it is
- do you want me to revert the tests' import lists? :-)
Also, I'd suggest to rename compile-java-test to compile-test-java to be
in line with other test related names such as test-java and so on. I did
it as a part of new version of the submitted patch.
Cos
> Converting JUnit tests into TestNG controlled environment
> ---------------------------------------------------------
>
> Key: AVRO-26
> URL: https://issues.apache.org/jira/browse/AVRO-26
> Project: Avro
> Issue Type: Test
> Components: java, python
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Attachments: AVRO-26.patch.1, AVRO-26.patch.2
>
>
> TestNG is a powerful test harness, which provides a lot of useful features
> like parallel test execution, test parametrization, and such.
> Avro uses JUnit environment instead which is more rigid and less efficient.
> I'd suggest to convert Avro's Junit based test infrastructure into TestNG
> controller environment, which will allow to achieve higher level of test
> execution control in the long run
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
