Doug Cutting wrote:
I have created a second candidate build for Avro release 1.0.0.
Mostly this adds missing license headers and notices.

-1, tests all pass however a few files are still flagged by RAT, a few of those seem valid:

---------------
The full list of ???? from rat attached, here's what I think is still at issue:

 !????? ./src/c++/scripts/gen.py
 !????? ./src/c++/parser/avro.l
 !????? ./src/c++/parser/avro.y
 !????? ./src/c/json_schema.y

---------------
The following are most likely OK but you should verify:

these two files have "disclaimer of c/r at the top"
 !????? ./src/c/lemon.c
 !????? ./src/c/lempar.c

empty file (probably should just be removed?):
 !????? ./src/c++/impl/ValidatingSerializer.cc

do these need license? they seem to be tests, perhaps for safety sake?
 !????? ./src/schemata/org/apache/avro/ipc/HandshakeRequest.m4
 !????? ./src/schemata/org/apache/avro/ipc/HandshakeResponse.m4
 !????? ./src/schemata/org/apache/avro/ipc/MD5.js

src/c/json* & /src/c++/json* -- these are tests or what? do they need
  license files?

-------------
Full list of issues reported by RAT:
 !????? ./CHANGES.txt
 !????? ./avro-1.0.0.jar.md5
 !????? ./avro-1.0.0.jar.sha1
 !????? ./avro-1.0.0.pom
 !????? ./avro-1.0.0.pom.md5
 !????? ./avro-1.0.0.pom.sha1
 !????? ./c/Linux-i386-32/lib/libavro.la
 !????? ./doc/broken-links.xml
 !????? ./doc/index.html
 !????? ./doc/linkmap.html
 !????? ./doc/spec.html
 !????? ./doc/api/java/package-list
 !????? ./doc/api/py/avro.genericio.html
 !????? ./doc/api/py/avro.io.html
 !????? ./doc/api/py/avro.reflectio.html
 !????? ./doc/api/py/avro.schema.html
 !????? ./doc/skin/note.txt
 !????? ./doc/skin/profile.css
 !????? ./lib/asm-3.0-LICENSE.txt
 !????? ./lib/paranamer-1.5-LICENSE.txt
 !????? ./lib/slf4j-1.5.8-LICENSE.txt
 !????? ./lib/py/odict-LICENSE.txt
 !????? ./lib/py/odict.py
 !????? ./lib/py/simplejson/__init__.py
 !????? ./lib/py/simplejson/_speedups.c
 !????? ./lib/py/simplejson/decoder.py
 !????? ./lib/py/simplejson/encoder.py
 !????? ./lib/py/simplejson/scanner.py
 !????? ./lib/py/simplejson/tool.py
 !????? ./src/c/.gitignore
 !????? ./src/c/Makefile.am
 !????? ./src/c/Makefile.in
 !????? ./src/c/config.h.in
 !????? ./src/c/configure
 !????? ./src/c/configure.in
 !????? ./src/c/json_schema.y
 !????? ./src/c/lemon.c
 !????? ./src/c/lempar.c
 !????? ./src/c/autom4te.cache/output.0
 !????? ./src/c/autom4te.cache/output.1
 !????? ./src/c/autom4te.cache/traces.0
 !????? ./src/c/autom4te.cache/traces.1
 !????? ./src/c/config/config.guess
 !????? ./src/c/config/config.sub
 !????? ./src/c/config/depcomp
 !????? ./src/c/config/install-sh
 !????? ./src/c/config/ltmain.sh
 !????? ./src/c/config/missing
 !????? ./src/c/docs/doxygen.conf
 !????? ./src/c/json/fail/array_not_closed
 !????? ./src/c/json/fail/array_not_opened
 !????? ./src/c/json/fail/array_with_start_coma
 !????? ./src/c/json/fail/object_malformed
 !????? ./src/c/json/fail/object_not_closed
 !????? ./src/c/json/fail/object_not_opened
 !????? ./src/c/json/fail/object_with_start_coma
 !????? ./src/c/json/fail/object_with_string
 !????? ./src/c/json/fail/object_without_one_value
 !????? ./src/c/json/pass/array_multidimensional
 !????? ./src/c/json/pass/array_with_false
 !????? ./src/c/json/pass/array_with_ints
 !????? ./src/c/json/pass/array_with_null
 !????? ./src/c/json/pass/array_with_objects
 !????? ./src/c/json/pass/array_with_string
 !????? ./src/c/json/pass/array_with_true
 !????? ./src/c/json/pass/empty_array
 !????? ./src/c/json/pass/empty_object
 !????? ./src/c/json/pass/object_with_false
 !????? ./src/c/json/pass/object_with_multiple_members
 !????? ./src/c/json/pass/object_with_null
 !????? ./src/c/json/pass/object_with_object_member
 !????? ./src/c/json/pass/object_with_one_member
 !????? ./src/c/json/pass/object_with_true
 !????? ./src/c++/Doxyfile
 !????? ./src/c++/Makefile
 !????? ./src/c++/System.Darwin.mk
 !????? ./src/c++/System.Linux.mk
 !????? ./src/c++/impl/ValidatingSerializer.cc
 !????? ./src/c++/jsonschemas/array
 !????? ./src/c++/jsonschemas/bigrecord
 !????? ./src/c++/jsonschemas/enum
 !????? ./src/c++/jsonschemas/fixed
 !????? ./src/c++/jsonschemas/nested
 !????? ./src/c++/jsonschemas/nested.error
 !????? ./src/c++/jsonschemas/recinrec
 !????? ./src/c++/jsonschemas/record
 !????? ./src/c++/jsonschemas/record2
 !????? ./src/c++/jsonschemas/union
 !????? ./src/c++/jsonschemas/unionwithmap
 !????? ./src/c++/parser/avro.l
 !????? ./src/c++/parser/avro.y
 !????? ./src/c++/scripts/gen.py
 !????? ./src/schemata/org/apache/avro/ipc/HandshakeRequest.m4
 !????? ./src/schemata/org/apache/avro/ipc/HandshakeResponse.m4
 !????? ./src/schemata/org/apache/avro/ipc/MD5.js
 !????? ./src/test/schemata/FSData.avpr
 !????? ./src/test/schemata/interop.avsc
 !????? ./src/test/schemata/simple.avpr

Reply via email to