[ 
https://issues.apache.org/jira/browse/AVRO-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thiruvalluvan M. G. updated AVRO-88:
------------------------------------

    Attachment: AVRO-88.patch

Good catch Ravi. Your patch is fine. The problem must have been caught in the 
unit tests. Now I added more unit tests which catch this bug and exercises 
larger portion of blocking encoder.

So the new patch has the original change Ravi made plus the new unit tests.

> BlockingBinaryEncoder should override writeEnum() method
> --------------------------------------------------------
>
>                 Key: AVRO-88
>                 URL: https://issues.apache.org/jira/browse/AVRO-88
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Ravi Gummadi
>            Assignee: Ravi Gummadi
>         Attachments: AVRO-88.patch, AVRO-88.patch
>
>
> When I was experimenting with BlockingBinaryEncoder to write objects into a 
> file, I see that writeEnum() is missing in BlockingBinaryEncoder. So 
> BinaryEncoder's writeEnum() was getting called. Where as all other things are 
> written to buffer of BlockingBinaryEncoder, only enum is directly written to 
> to outputStream, breaking the overall order in which objects are to be 
> written to(as buffer is flushed only after reaching a limitSize).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to