[ 
https://issues.apache.org/jira/browse/AVRO-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747620#action_12747620
 ] 

Doug Cutting commented on AVRO-104:
-----------------------------------

A few minor nits:
 - Paranamer might not be thread safe, so it should probably not be static.
 - The null checks seem excessive and not that informative.  Folks will fail 
soon enough if they pass a null here and this will be caught in debugging, long 
before production.  None of the other parameters are null-checked.

Other than that, this looks good to me.


> Reflective API can't handle nulls
> ---------------------------------
>
>                 Key: AVRO-104
>                 URL: https://issues.apache.org/jira/browse/AVRO-104
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.0.0, 1.0.1
>            Reporter: Eelco Hillenius
>             Fix For: 1.0.1
>
>         Attachments: AVRO-104.patch, AVRO-104.patch, AVRO-104.patch, 
> AVRO-104.patch, AVRO-104.patch, AVRO-104.patch, AVRO-104.patch
>
>
> It is currently not possible to have fields with null values when using the 
> reflective API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to