[ 
https://issues.apache.org/jira/browse/AVRO-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766111#action_12766111
 ] 

Doug Cutting commented on AVRO-149:
-----------------------------------

This is a great addition! 

> I chose to have two scripts to make it way obvious what's going on.

I think this will prove confusing.  Can you please fold these together?  We can 
add build/classes and build/lib when they exist.  This is what Hadoop's done 
for years.

> I added a dependency on google collections for avrotool.

If this is easy to avoid then I'd prefer it.  I don't know how we're getting 
that, but it's not currently an explicit dependency and we should add those 
more cautiously.

> Do you think sitting on the name "avrotool" is bad? I could do "avrojtool"?

I'd vote for either just 'avro' or perhaps 'avroj'.  This will be the primary 
(java-based) command-line interface to Avro, so we needn't further qualify it.

> I feel bad that the tests aren't automated: suggestions? Shell script invoked 
> by ant?

Guilt is good!  A shell script invoked by ant that checks return status and 
output would be fabulous.

> "avrotool" runner to execute avro commands from command-line
> ------------------------------------------------------------
>
>                 Key: AVRO-149
>                 URL: https://issues.apache.org/jira/browse/AVRO-149
>             Project: Avro
>          Issue Type: New Feature
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>         Attachments: AVRO-149.patch.txt
>
>
> There's already an ant task to generate java code based on a schema, but you 
> can't do it from the command-line, with any ease.  I will shortly upload a 
> patch that does just that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to