[ 
https://issues.apache.org/jira/browse/AVRO-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Hammerbacher updated AVRO-161:
-----------------------------------

    Attachment: AVRO-161.patch

I've gotten this code path working in a slightly unusual fashion: I implemented 
Philip's suggestion in AVRO-158 to have a factory method called 
DataFileWriter.create_for_append() and I also added a factory method 
DataFileWriter.create_new() to replace the old, plain constructor. These new 
methods are implemented using Python's @classmethod decorator.

It's been a while since I wrote production code, so this implementation may be 
hacky. I've gotten it working for realz in a script that you can see at 
http://github.com/hammer/avro-rpc-quickstart/blob/master/src/main/python/serialize_message.py.
 I will turn that patch into a new test in testio.py once I get confirmation on 
the approach I've taken.

Looking forward to the feedback!

Thanks,
Jeff

> Add test to Python bindings for opening a non-empty file object container and 
> successfully adding new elements
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-161
>                 URL: https://issues.apache.org/jira/browse/AVRO-161
>             Project: Avro
>          Issue Type: Test
>            Reporter: Jeff Hammerbacher
>         Attachments: AVRO-161.patch
>
>
> Avro file object container are mutable and we should test that fact. 
> testio.py currently just tests open a file for writing, writing a few 
> records, closing the file, then reading the file back in.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to