[
https://issues.apache.org/jira/browse/AVRO-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776352#action_12776352
]
Philip Zeyliger commented on AVRO-185:
--------------------------------------
This patch is a little tricky to follow, though most of it seems like moving
code around. I assume that src/java/org/apache/avro/reflect/FixedSize.java is
moved to src/java/org/apache/avro/specific/FixedSize.java as part of this patch?
I noticed that there's some support for nested classes (space =
c.getEnclosingClass().getName() + "$"); That looked like new code; is there a
small test with nested classes?
I'm confused why SpecificData.createSchema() uses reflection to generate the
schema. "Specific" indicates that this uses the generated code, and the
generated code has a schema object already there, waiting to be parsed. It
seems like before this patch, there were two implementations of createSchema(),
and there's only one left. Was that intentional?
Otherwise, everything looks good.
-- Philip
> specific should not depend on reflect
> -------------------------------------
>
> Key: AVRO-185
> URL: https://issues.apache.org/jira/browse/AVRO-185
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-185.patch
>
>
> Currently the specific implementation inherits from the reflect
> implementation. To fix AVRO-80, this dependency should be reversed, since
> specific will still share all data representations but records and enums with
> generic, but specific and reflect will no longer use common representations
> for strings and arrays.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
