[ 
https://issues.apache.org/jira/browse/AVRO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Cutting updated AVRO-182:
------------------------------

    Attachment: AVRO-182.patch

> would it be reasonable to assert "space==null" in the case where name 
> contains a "."

I don't think so.  If the name is fully qualified, then the namespace should be 
ignored. When parsing a nested schema that specifies no namespace, the 
namespace of the containing schema is passed.  But we should support using a 
fully-qualified name in place of a namespace declaration.  And, if someone 
specifies both a fully-qualified name and a namespace, I think the 
fully-qualified name should win, as the namespace is like a package 
declaration, determining only the default.

Here's a new patch with the tests you suggested added.

> hashCode and equals are not consistent with compareTo
> -----------------------------------------------------
>
>                 Key: AVRO-182
>                 URL: https://issues.apache.org/jira/browse/AVRO-182
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-182.patch, AVRO-182.patch, AVRO-182.patch, 
> AVRO-182.patch
>
>
> Java's specific and generic APIs implement compareTo according to the schema, 
> where some fields might be ignored.  To be consistent, fields that are 
> ignored when comparing for ordering should also be ignored when comparing for 
> equality and for computing hashCodes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to