[ https://issues.apache.org/jira/browse/AVRO-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779698#action_12779698 ]
Jeff Hammerbacher commented on AVRO-199: ---------------------------------------- One question on this patch: what do folks think of appending "_" to reserved words when you'd like to use them as variable names? In PEP 8 (), the relevant section states: {noformat} - single_trailing_underscore_: used by convention to avoid conflicts with Python keyword, e.g. Tkinter.Toplevel(master, class_='ClassName') {noformat} I changed "string" to "string_" and "schm" to "schema_" for improved readability here, but not everyone likes the trailing underscore. Happy to hear thoughts. Thanks, Jeff > Clean up schemas in testio.py > ----------------------------- > > Key: AVRO-199 > URL: https://issues.apache.org/jira/browse/AVRO-199 > Project: Avro > Issue Type: Improvement > Components: python > Reporter: Jeff Hammerbacher > Assignee: Jeff Hammerbacher > Attachments: AVRO-199.patch, AVRO-199.patch > > > As discussed on the mailing list, it would be nice to leverage Python's > expressive string syntax to not perform lots of escaping of Avro schemas > defined in code and make the schemas more readable. > This patch cleans up schemas in testio.py to make them more readable. Note > that to get this to pass the tests, I had to implement a new > "remove_whitespace()" helper function to replace the current naive approach > to replacing whitespace (s.replace(" ", "") is not going to cut it). I also > object to the round-trip string conversion test, as noted in the comments to > this patch, but I'll save that change for another patch to better separate > concerns. > If this code change is deemed useful, I'll convert the rest of the schemas in > the Python code to leverage Python's string formatting. I have a ridiculously > naive tool that I used for schema conversion that I threw up at > http://github.com/hammer/avro-tools/blob/master/pprint_avsc for those > interested. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.