[
https://issues.apache.org/jira/browse/AVRO-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Cutting updated AVRO-278:
------------------------------
Attachment: AVRO-278.patch
> Eclipse is teling me this is unnecessary now.
Removed.
> Does the Avro code-base typically put the @Override annotation for
> implemented interface methods?
It should but does not consistently. I've added them here.
> I believe this is unused.
Removed.
> This is an incompatible change, since the interface is changed significantly.
Yes, the change message would go in the INCOMPATIBLE section of CHANGES.txt.
> The JavaDoc should indicate where the field numbers must come from.
Added.
> GenericRecord.java: "A set of fields, each a name/value pair."
> Does that make sense as an explanation?
Changed to "An instance of a record schema".
> It may also be worth nothing that to re-use a GenericRecord, you can set all
> the fields to "null". (Or is that not the right thing?)
Before reusing it already checks that the schema is identical. Fields that are
not overwritten are automatically set to null by GenericDatumReader.
> use array instead of map to implement generic records
> -----------------------------------------------------
>
> Key: AVRO-278
> URL: https://issues.apache.org/jira/browse/AVRO-278
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-278.patch, AVRO-278.patch
>
>
> It would be considerably faster to implement GenericData.Record as an array
> rather than as a HashMap. We expect generic data to be a major incentive to
> using Avro, and users of Java's generic API should not pay a performance
> penalty.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
