[
https://issues.apache.org/jira/browse/AVRO-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Zeyliger updated AVRO-152:
---------------------------------
Attachment: AVRO-152.patch.txt
bq. the patch is stale, since I took so long to review it. Sorry!
No worries. I've updated the patch.
It's always strangely pleasant when patches go stale because there are new
features to adapt to.
bq. why all the SpecificCompiler#doc() methods? Why not just call, e.g.,
doc(out, indent, schema.getDoc())?
It was a good idea when there were only 2 types, and it felt cleaner. Fixed it
to just use String and one doc() method. Avoided the temptation to introduce a
"hasDoc" interface.
bq. shouldn't we now also extend avrogen to copy comments through?
I've filed AVRO-296. It needs to be done, but it's not 100% trivial (because
javacc strips out comments, and that needs to get undone), so I'd rather take a
pass at it separately.
> Adding "doc" to record schemas, a la javadoc field and class comments.
> ----------------------------------------------------------------------
>
> Key: AVRO-152
> URL: https://issues.apache.org/jira/browse/AVRO-152
> Project: Avro
> Issue Type: New Feature
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Attachments: AVRO-149.patch.txt, AVRO-152.patch.txt,
> AVRO-152.patch.txt, AVRO-152.patch.txt, AVRO-152.patch.txt
>
>
> The patch to follow adds "doc" to the understood schema language (for records
> and enums), and uses said doc when it generates java in SpecificCompiler.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
