--
Stefano Verna
mail/gtalk: [email protected]
skype: steffoz
Il giorno 21/feb/09, alle ore 17:45, Antonio Terceiro <[email protected]
> ha scritto:
Hi,
Stefano escreveu isso aí:
I'm attaching you a patch for freedesktop package to show also dirs
and icons contained in ~/Desktop. It parses the system MIME types to
find the right icons. Please comment it.
It looks nice, thanks for working on that. I have some comments,
though:
0) would you please rebase your work off the current code. It seems
you
reverted several recent changes to the code organization. In
special, stick to
the current interface of the functions (i.e. using actual, explicit
arguments
instead of single-table-argument functions)
1) please make sure there are no trailing whitespace. git diff --
check helps
with that. (plus a plain git diff will highlight trailing whitespace
if you
have color enabled (`git config --global color.ui auto`).
2) I'm not sure it's usefull to add explictly both application and
file icons.
Why don't we have a single add_destkop_icons that does both things,
but without
exposing it to the user?
3) I also don't like splitting the icon lookup like that. Finding an
icon must
be a unique operation. Mind you, some applications actually use
mimetype icons
as icons for their launchers, so I don't differentiating the icon
lookup like
that will help us.
The only problem is it doesn't get refreshed on FS change.. any way I
could solve it?
Maybe registering a function with the timer, just like the one which
updates
the clock etc.
awful.hooks.timer.register(1, function ()
-- check for updates in ~/Desktop
end)
But not every 1 second, I guess. ;-)
--
Antonio Terceiro <[email protected]>
http://people.softwarelivre.org/~terceiro/
GnuPG ID: 0F9CB28F
--
To unsubscribe, send mail to [email protected].
