At 1237518867 time_t, Alex Cornejo wrote: > Thanks to Andrei I think I managed to merge my patches.
Actually, you should have merged this 2 also.
If I apply only patch one, awesome does not build anymore, which is not
acceptable. Merging both patches, it compiles correctly, so I did this.
Plus a couple of edition.
I'll comment some stuff, just see this as information you can reuse
later if you continue working on awesome, which I hope. :)
> diff --git a/common/socket.c b/common/socket.c
> index 3fb9b68..9119e03 100644
[…]
> + if(!bind(csfd, (const struct sockaddr *) addr,
> SUN_LEN(addr)))
> + status = 0;
You missed the moving of SUN_LEN from luaa.c, which is defined in luaa.c
if not defined. It'd fails to compile on some weird OS.
> + if (status == -1)
> {
> - fprintf(stderr, "error: path of control UNIX domain socket is too
> long");
> - return NULL;
> + p_delete(&addr);
> + addr=NULL;
> }
FWIW, you don't need to addr = NULL, p_delete does it for you.
Rest seemed ok.
Cheers,
--
Julien Danjou
// ᐰ <[email protected]> http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
// Tomorrow I was nothing, yesterday I'll be.
signature.asc
Description: Digital signature
