At 1247096479 time_t, Gregor Best wrote: > The layouts now > use the "bounds" parameter only to determine the available width and > height they can put their widgets into, the X and Y coordinates are > modified by the calling functions. (A much cleaner approach, why didn't > I think of that? :)
Don't know. Why do you keep this bounds?
You seems to only use them to check if the widgets does not try to
render outside the wibox/layouts. That's not the work of the layout.
If the widget, even packed, does not fit, well, too bad, it will be
drawn outside of the wibox, i.e. not shown.
> Subject: [PATCH 1/9] widgets: add bool widget_geometries(wibox_t *)
> @@ -276,7 +315,6 @@ widget_render(wibox_t *wibox)
> for(int i = 0; i < widgets->len; i++)
> if(widgets->tab[i].widget->isvisible)
> {
> - widgets->tab[i].geometry.y = 0;
> widgets->tab[i].widget->draw(widgets->tab[i].widget,
> ctx, widgets->tab[i].geometry,
> wibox);
> }
You can kill the brackets.
> --- a/widgets/graph.c
> +++ b/widgets/graph.c
> @@ -148,13 +148,13 @@ graph_plot_get(graph_data_t *d, const char *title)
> }
>
> static area_t
> -graph_geometry(widget_t *widget, screen_t *screen, int height, int
> width)
> +graph_geometry(widget_t *widget, int screen)
> {
> area_t geometry;
> graph_data_t *d = widget->data;
>
> geometry.x = geometry.y = 0;
> - geometry.height = height;
> + geometry.height = d->width;
> geometry.width = d->width;
>
Seems wrong to me. Why the graph would be a square?
> Subject: [PATCH 2/9] widgets: get rid of align attribute
OK.
> Subject: [PATCH 3/9] systray: don't crap up on odd-sized windows
OK.
> Subject: [PATCH 4/9] awful.widget: add layouts
OK.
> Subject: [PATCH 5/9] awesomerc.lua: add support for widget layouts
OK.
> Subject: [PATCH 6/9] naughty: add support for widget layouts
OK.
--
Julien Danjou
// ᐰ <jul...@danjou.info> http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
// My root password is
signature.asc
Description: Digital signature
