Excerpts from Uli Schlachter's message of Thu Jul 30 12:55:20 -0400 2009:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Andrei Thorp wrote:
> > Excerpts from Uli Schlachter's message of Thu Jul 30 09:43:46 -0400 2009:
> >> Andrei Thorp wrote:
> >>> @@ -97,25 +113,33 @@ function show_wibox(s)
> >>> })
> >>> runwibox[s].visible = true
> >>>
> >>> - f = function ()
> >>> - startgeom = runwibox[s]:geometry()
> >>> - runwibox[s]:geometry({
> >>> - y = startgeom.y - settings.move_amount,
> >>> - })
> >>> - if runwibox[s]:geometry().y <= screen[s].geometry.y +
> >>> - screen[s].geometry.height - startgeom.height then
> >>> - set_default(mouse.screen)
> >>> - awful.hooks.timer.unregister(f)
> >>> - end
> >>> + if lib.hooks.timer.has(do_slide_up) then
> >>> + lib.hooks.timer.start(do_slide_up)
> >>> + else
> >>> + lib.hooks.timer.register(settings.move_speed,
> >>> + settings.move_speed*3,
> >>> + do_slide_up,
> >>> + "popup_run_prompt slide up")
> >>> end
> >>> -
> >>> - awful.hooks.timer.register(settings.move_speed, f)
> >> I like the old code better which unregisters the timer when it's no longer
> >> needed (or at least get rid of that lib.hooks.timer.has() call somehow).
> >
> > I'll probably register the timer elsewhere and just pause it right away
> > then.
> >
> > Fixes to Timers pushed.
>
> Care to send the fix for review? *duck*
Nah. Almost everything you asked me to change here was cosmetic
subjective stuff. Some of it I changed, some of it I didn't. I don't
really see what's left to review at this point.
--
Andrei Thorp, Developer: Xandros Corp. (http://www.xandros.com)
--
To unsubscribe, send mail to [email protected].
