-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Julien Danjou wrote:
> At 1252069260 time_t, Uli Schlachter wrote:
>> IMHO this is the proper fix for the "c.screen == <some huge number>" bug I
>> had
>> recently when I accidentally used the client in client::new.
>
> Unfortunately, it's not the proper fix. If you call add_signal() on
> manage, will miss some property:: signals because some are emitted
> before "manage" is emitted.
>
> This is what we used new rather than manage in some awful code.
>
> The client code should be bulletproof about doing stuff on a client that
> is *being set up to be managed*. I've fix the issue you found, there's
> *maybe* more. And if there's more, we should fix them. :)
Just assume that all client properties are changed in "manage" and call the
update function like my patch does? Wouldn't that fix this problem as well?
Judging from my patch I think that atm there isn't anything which needs these
dangerous "early signals". :/
Uli
- --
"Do you know that books smell like nutmeg or some spice from a foreign land?"
-- Faber in Fahrenheit 451
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iQEcBAEBCAAGBQJKoR2EAAoJECLkKOvLj8sGabkH/1Mgl0seRX1kD7PuBJbiPPsq
DYeMq7sLd0Rdggdzu/9htx7TafDBWEei7upJZKs/7gASjtet0mBQpLsMoiWRYeTP
kTjFsN3TNkyChql7lozeBzY17DjvHSGZv2BSoqKroYy74aJbNObgsMB7xjERAiJ1
NLfQszDLH0LKT3fK+4oLO5EfqU8kJSkoLcRRWixlywIzOpthwGCL7HD91xdij4zb
P0HV2KHVvL8wXfuR6Wyt1SaM1QzedKbiPqggPIqc7k/GXv1BhK+z+hjtmz85ELS4
5l9dmUiSQT54QdKNiseKqZoKY6QLt8atIDFK0zt6p/A9NJktLjFWCpbEgwtiJRs=
=bY0m
-----END PGP SIGNATURE-----
--
To unsubscribe, send mail to [email protected].
