THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task has a new comment added:

FS#516 - Colorful background behind awesome's "a" menu
User who did this - Uli Schlachter (psychon)

----------
Ok, after some (not funny) debugging I got a patch for something different and 
I think this is imlib's fault.

awful.widget.button creates the image like this:
   img_press = img_release:crop(-2, -2, img_release.width, img_release.height)

This causes imlib_create_cropped_image() to be called. This function allocates 
a buffer for the new image but doesn't actually initialize it (why should it? 
It's going to be filled with the cropped content anyway).
But since we are cropping from some negative offset, some later functions skips 
the first two rows and lines of the image and leaves them unitialized.

I managed to make valgrind complain about this by using :save() on the cropped 
image (no idea why the normal painting doesnt cause a warning and the warning I 
get this way doesn't look completely right either).

We could perhaps work around this by doing the cropping "by hand" with 
imlib_image_copy_rect(). (I heard that imlib's upstream is quite dead these days, is that 
correct?)

----------

More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=516#comment1602

You are receiving this message because you have requested it from the Flyspray 
bugtracking system.  If you did not expect this message or don't want to 
receive mails in future, you can change your notification settings at the URL 
shown above.

--
To unsubscribe, send mail to [email protected].

Reply via email to