Hi,

if you read the users mailing list you already know by now and I don't have to explain this. If you don't read the user mailing list, I won't explain this. If you don't want to give me another commit, just 'git revert HEAD' yourself (assuming there is no new patch merged since my fail-commit).

Uli

P.S.: Please look at the Date header of this mail (aka at what time I'm still awake even though Sesamstraße is over)
From ad9703f7438cd58d7eb506255130857d7245333c Mon Sep 17 00:00:00 2001
From: Uli Schlachter <[email protected]>
Date: Mon, 28 Dec 2009 19:14:46 +0100
Subject: [PATCH] Revert "Handle synthetic UnmapNotify events"

This reverts commit 8e672897cb3321dbd245c9ed4e114ee0cdfbf425.
---
 event.c |   21 ++++-----------------
 1 files changed, 4 insertions(+), 17 deletions(-)

diff --git a/event.c b/event.c
index 38e61a1..370d9ae 100644
--- a/event.c
+++ b/event.c
@@ -665,23 +665,10 @@ event_handle_unmapnotify(void *data __attribute__ 
((unused)),
 
     if((c = client_getbywin(ev->window)))
     {
-        if(ev->event == xutil_screen_get(connection, c->phys_screen)->root)
-        {
-            if(!XCB_EVENT_SENT(ev))
-            {
-                /* A regular UnmapNotify, remove that client from our lists */
-                client_unmanage(c);
-            }
-            else
-            {
-                /* According to ICCCM 4.1.4 a client sends a synthetic
-                 * UnmapNotify when it wants to switch to Widthdrawn state.
-                 * We handle these by unmapping the client and waiting for the
-                 * "real" UnmapNotify.
-                 */
-                xcb_unmap_window(connection, ev->window);
-            }
-        }
+        if(ev->event == xutil_screen_get(connection, c->phys_screen)->root
+           && XCB_EVENT_SENT(ev)
+           && xwindow_get_state_reply(xwindow_get_state_unchecked(c->window)) 
== XCB_WM_STATE_NORMAL)
+            client_unmanage(c);
     }
     else
         for(int i = 0; i < globalconf.embedded.len; i++)
-- 
1.6.5.7

Reply via email to