THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#503 - awesome "steals" gnome systray even when its systray is disabled
User who did this - Daniel Graña (dangra)
----------
@psychon
Patch was rejected by jd but he suggested proper fix:
| The ideal patch would be to enable systray window only at systray widget
| creation, and destroy it on widget destruction.
For using xcb_set_selection_owner() with XCB_NONE: This will cause a BadWindow
error from the server, wouldn't it make more sense to just not call that function
at all, if it's not needed? :P
I am learning xcb/X in the process of fixing this issue, so thanks for pointing
the difference.
I choose between not doing any selection (not calling xcb_set_selection_owner) versus clear the selection
using XCB_NONE just like systray_cleanup does hoping that doing clearing the selection won't fail.
If calling with XCB_NONE fails at systray_init, it will fail at systray_cleanup too
but nobody will notice it because it's just leaving awesome.
But as said, patch needs to be reworked to register/select systray only if a
systray widget is created.
thanks!
----------
More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=503#comment1975
You are receiving this message because you have requested it from the Flyspray
bugtracking system. If you did not expect this message or don't want to
receive mails in future, you can change your notification settings at the URL
shown above.
--
To unsubscribe, send mail to [email protected].
