THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#503 - awesome "steals" gnome systray even when its systray is disabled
User who did this - Uli Schlachter (psychon)
----------
Despite some grammar stuff ("Has wibox an attached systray") I feel like
systray_refresh() seems bad. It needlessly walks all wiboxes on each update. Wouldn't it
make more sense to call systray_register() directly from wibox_refresh() *only* when the
has_systray value changes?
(Also, wtf @ the foreach loop in systray_refresh()? Are you really or-ing value into a
boolean? Just set that one to true and "break;"?!)
Besides that, the code seems sane. Now let's do some testing...
Results:
- Alltray sucks. Never use it!
- Patch doesn't seem to break my config
- Alltray annoyed me enough so that I don't feel like adding/removing systrays
dynamically, sorry
I'd vote for jd testing this himself and/or merging the next version of the
patches (really, no need to walk all the wiboxes).
Oh and sorry if I sound harsh, I don't mean stuff as unfriendly as I write it.8
----------
More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=503#comment2046
You are receiving this message because you have requested it from the Flyspray
bugtracking system. If you did not expect this message or don't want to
receive mails in future, you can change your notification settings at the URL
shown above.
--
To unsubscribe, send mail to [email protected].
