THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#778 - Clients with nofocus hint but with TAKE_FOCUS protocol doesn't hit
into focus history
User who did this - Uli Schlachter (psychon)
----------
Now for the patch: It makes awesome emit the "focus" signal when it sends the
WM_TAKE_FOCUS, even though the app doesn't have the input focus at that time
Patch only places windows with WM_TAKE_FOCUS into focus history. Awesome sent
such signal before this fix. For example by clicking window title in tasklist.
And swing windows take focus in this case because have WM_TAKE_FOCUS protocol.
Windows with WM_TAKE_FOCUS stil get "focus" emitted on their windows through
event.c and the focusin event handler.
What's the problem you are trying to fix?
From by user experience awesome behaves very strange. One allows window
focusing by clicking in tasklist but does not place it in history. And I can't
navigate by MOD+k/j.
When the window gets the focus (i.e. it's border color is changed to the "focus" one),
then the "focus" signal was emitted. So the appropriate signals in the focus history code
have to run then, too. :/ And navigating with MOD+k/j doesn't seem to have anything to do with your
patch.
I don't see how any app could avoid being added to the focus history.
Apps with "No Input" focus model -- input focus = false and without
WM_TAKE_FOCUS protocol. xclock and xload as examples.
Well, those apps can't be focused either. If they cannot be focused, they
cannot be added to the focus history either. This sounds a lot like FS#716
which was fixed by making awful skip over unfocusable clients in next().
----------
More information can be found at the following URL:
http://awesome.naquadah.org/bugs/index.php?do=details&task_id=778#comment2231
You are receiving this message because you have requested it from the Flyspray
bugtracking system. If you did not expect this message or don't want to
receive mails in future, you can change your notification settings at the URL
shown above.
--
To unsubscribe, send mail to [email protected].
