Re: Typo in naughty.lua?

[Matthias]

On 2010-11-10 Uli Schlachter wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Am 10.11.2010 12:36, Matthias wrote:
> > in latest git i missed several notifications and the logs showed me
> > 
> > W: awesome: luaA_dofunction:108: error while running function
> > stack traceback:
> >     /usr/local/share/awesome/lib/naughty.lua:533: in function
> > </usr/local/share/awesome/lib/naughty.lua:483>
> > error: /usr/local/share/awesome/lib/naughty.lua:533: attempt to index
> > field 'image' (a nil value)
> > 
> > the appended patch fixed the problem for me.
> 
> Thanks a lot for this. When writing that, I tried to find a way to test it, 
> but
> couldn't find one. How can you make this happen?
> 

It appears with the mail notification send by sylpheed-claws, i have
the notification-plugin enabled to send "Popups" (from
http://www.claws-mail.org/plugins.php or debian package
claws-mail-multi-notifier).

I attached the dbus-monitor log.

> Also, could you send a properly signed off patch so that you are tracked as 
> the
> author?
> A quick google only found this "tutorial" (the "With git" stuff applies here):
> http://www.gimp.org/bugs/howtos/submit-patch.html
> 

Sure, and thanks for the link - honestly my problem was that i did not
know that i could commit my local patches, until now i just patched and
stored the diffs, but without commiting no format-patch 

> Cheers,
> Uli

Thanks for the good work,

Matthias

> - -- 
> Q: Because it reverses the logical flow of conversation.
> A: Why is putting a reply at the top of the message frowned upon?
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> 
> iQEcBAEBCAAGBQJM2vlSAAoJECLkKOvLj8sGa9YH/RiqhKSreHNeshyXnoQgzKyU
> 7UrvgpLE3xpaTv7GRbnrRWXU1eLjQ5XCCgzDBtpCUhAnjYBx0OepTBOZ5hBTtvmB
> rHFx0mSss469x29S8h0B3PW+W4es1bIznqdZkVqWM4QZg5SFvooSdhYSmh5ZRLaN
> 7xUi/aTaBKqa656ojCs4NlkQCtHJgjC8osTiFqwgM4idfi7nZOfGI4j7pxa4pHIj
> XNqYuvWDVxGpLEZYSaVesTCPVkuIfkX8ck/3a/RFW6qiau1p6B8LJXi1n38yj3Sw
> R/3Ah2MQmpH6hWv1hfN5HlBLHVAyf/jq6iXItMOtIKRAYc92hpEEtYmNL2i6ZFA=
> =sZoY
> -----END PGP SIGNATURE-----
> 

dbus.log.gz
Description: GNU Zip compressed data

From 672fa925702b053e4be044373dedc85484586c1f Mon Sep 17 00:00:00 2001
From: Matthias <m...@softimpulse.de>
Date: Thu, 11 Nov 2010 08:59:03 +0100
Subject: [PATCH] Fixed oocairo.image_surface_create_... typo

its oocairo.image_surface_create_from_data not oocairo.image.surface...
---
 lib/naughty.lua.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/naughty.lua.in b/lib/naughty.lua.in
index 144d953..9240c3f 100644
--- a/lib/naughty.lua.in
+++ b/lib/naughty.lua.in
@@ -530,7 +530,7 @@ if capi.dbus then
                     end
                 end
                 if imgdata then
-                    args.icon = capi.oocairo.image.surface_create_from_data(imgdata, "argb32", hints.icon_data[1], hints.icon_data[2], hints.icon_data[1] * 4)
+                    args.icon = capi.oocairo.image_surface_create_from_data(imgdata, "argb32", hints.icon_data[1], hints.icon_data[2], hints.icon_data[1] * 4)
                 end
             end
             if replaces_id and replaces_id ~= "" and replaces_id ~= 0 then
--
1.7.1