THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added:
FS#888 - add ban and unban client signals User who did this - Uli Schlachter (psychon) ---------- Also, the way your patch works, stuff can easily break. E.g. just change the text of a textbox or the currently focused client. I haven't actually checked the code (depends on the order of stuff done in awesome_refresh()), but with some luck some of these changes will only be applied after the next main loop iteration (and it can arbitrary long until that happens). Basically, the rule for all the stuff called from awesome_refresh() is "don't call any lua code, or stuff might break (= changes aren't applied ASAP)". If you really want to do something like this, you'd have to emit these signals from banning_need_update(). However, at that point you don't know which client will be banned/unbanned, so you have to loop over all of them and.... Basically, doing this in the C core would require the same approach as I did for lua above, but it would be a lot longer (minus having banning_need_update() instead of all the individual signals). ---------- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=details&task_id=888#comment2613 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to [email protected].
