> I guess I'm fine with this behavior, but I just managed to confuse myself
> (not your fault, but the existing code's fault).
>
> Are you fine with changing the code like this?

Yup.

>  if c == client.focus then
>     -- Clicking on a focused client minimizes it
>     c.minimized = true

In fact this is more correct. I was expecting you to say something
here. I used c.minimized = not c.minimized just to be consistent with
the previous usage in clientkeys, which probably should change to:

    awful.key({ modkey,           }, "n",      function (c)
c.minimized = not c.minimized    end),

This gives the impression that another mod + n will un-minimize the
client but it does not. Right?

[...]

> I added two comments and changed "c.minimized = not c.minimized" into
> "c.minimized = true". If you are OK with this, I'd like to sneak this
> changes into your patch and let it look like you came up with this. :-)

Sure. No issues :).

-- 
Anurag Priyam
http://about.me/yeban/

--
To unsubscribe, send mail to [email protected].

Reply via email to