On 21.02.2012 16:59, Anurag Priyam wrote: > On Tue, Feb 21, 2012 at 9:25 PM, Uli Schlachter <[email protected]> wrote: >> I was going to complain that this breaks awful, however a closer look >> revealed >> that everything in there only ever does 'return true'. > > Yeah, I checked that actually :). > >> Still, how about a patch which removes some superfluous return statements and >> 'return true's from lua? :-) > > I was thinking why bother if it works. On second thought, we should > remove `return true` to avoid confusion. Another patch would do, or > you want the changes squashed into one?
Another patch is fine with me. One logical change per patch is better than a "fix stuff" commit. :-) >> Will merge when I find the time (= not before friday). > > No problems :). It took a little longer than Friday, but: merged! Actually, I didn't say which Friday was meant, so I'm still on time! (Patch not cherry-picked into 3.4 since it changes API) Uli -- "In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move." -- To unsubscribe, send mail to [email protected].
