On 26.02.2012 05:26, Anurag Priyam wrote: > On Sun, Feb 26, 2012 at 9:31 AM, Anurag Priyam <[email protected]> > wrote: >> On Fri, Feb 17, 2012 at 10:24 PM, Uli Schlachter <[email protected]> wrote: >>> You might be interested in the following commit: >>> >>> commit 2216b6a341ddb840200ea85207f8a59a5b3d61a6 >>> Author: Uli Schlachter <[email protected]> >>> Date: Fri Feb 17 17:48:11 2012 +0100 >>> >>> gears.color: Add table-based color definitions >>> >>> Signed-off-by: Uli Schlachter <[email protected]> >>> >>> The syntax is almost identical to what you proposed above. The only >>> difference >>> is that I went with "type" instead of "gradient". > > And I caught a bug that you introduced :D. > > [...] > Subject: [PATCH] gears.color: call the correct creator function in local > string_pattern function > > The corresponding pattern factory that `string_pattern` delegates to is stored > in the `creator` parameter, and not `v`; probably a typo. > > Signed-off-by: Anurag Priyam <[email protected]> > --- > lib/gears/color.lua.in | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/gears/color.lua.in b/lib/gears/color.lua.in > index d285c4a..1299ff6 100644 > --- a/lib/gears/color.lua.in > +++ b/lib/gears/color.lua.in > @@ -105,7 +105,7 @@ local function string_pattern(creator, arg) > table.insert(args, v) > end > -- And call our creator function with the values > - local p = v(unpack(args)) > + local p = creator(unpack(args)) > > add_iterator_stops(p, iterator) > return p > > Copy-paste error? Looks like a reminiscent of the older metatable hack.
Whoops, thanks. -- "In the beginning the Universe was created. This has made a lot of people very angry and has been widely regarded as a bad move." -- To unsubscribe, send mail to [email protected].
