-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi,
the patch itself looks fine to me. The commit message could need some love (e.g. shorter summary), but I can live with that. However: $ git am -s /tmp/fetch\>UID\>.awesome-dev\>5322.awesome-dev%3E5322 * Running commit-msg hook warn: Summary is a bit long. (60 characters) Applying: Return condition value instead of conditional true/false in fatal: patch fragment without header at line 22: @@ -213,10 +212,7 @@ end Patch failed at 0001 Return condition value instead of conditional true/false in When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Could you re-send with the result from git format-patch attached as a file? Thanks, Uli (Oh and I don't think that that the current state is more readable than what you suggest) On 11.05.2012 17:09, felix wrote: > From 6022805772c5f2897699f1e825f030e5db4635d7 Mon Sep 17 00:00:00 2001 > From: Felix <[email protected]> Date: Fri, 11 May 2012 16:52:24 > +0200 Subject: [PATCH] Return condition value instead of conditional > true/false in tasklist.filter.{currenttag,focused} > > Patterns like > > if condition then return true else return false end > > could be simplified to > > return condition > > Is that something wanted in the awesome code base? I'm fine with the > rejection of this patch in favour of readability. > > Signed-off-by: Felix <[email protected]> --- > lib/awful/widget/tasklist.lua.in | 8 ++------ 1 Datei geändert, 2 Zeilen > hinzugefügt(+), 6 Zeilen entfernt(-) > > diff --git a/lib/awful/widget/tasklist.lua.in > b/lib/awful/widget/tasklist.lua.in index c52e4cd..c3c47ef 100644 --- > a/lib/awful/widget/tasklist.lua.in +++ b/lib/awful/widget/tasklist.lua.in > @@ -154,8 +154,7 @@ end -- @return true if c is on screen, false otherwise > function filter.alltags(c, screen) -- Only print client on the same screen > as this widget - if c.screen ~= screen then return false end - return > true + return c.screen == screen end > > --- Filtering function to include only the clients from currently selected > tags. @@ -213,10 +212,7 @@ end -- @return true if c is focused on screen, > false otherwise function filter.focused(c, screen) -- Only print client on > the same screen as this widget - if c.screen == screen and > capi.client.focus == c then - return true - end - return > false + return c.screen == screen and capi.client.focus == c end > > setmetatable(_M, { __call = function(_, ...) return new(...) end }) - -- - - Buck, when, exactly, did you lose your mind? - - Three months ago. I woke up one morning married to a pineapple. An ugly pineapple... But I loved her. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQEcBAEBCAAGBQJPrS5vAAoJECLkKOvLj8sGG7UIAIypQCw1Y0Jfx3bubPR2FGJ9 Mv1gVzhLsTcLXCPBtmbR3XPZGV4ij34U2dv9nA3PYfXGMRPE7ANvyXOJzhBrgUMq KhPjRW6ozHEisN6sSFSKF1tDUPTFwCjKxnJ7Cmb7ZglLEjSk5XZ6IeI6FBajC7WR AiotlUF/4Kh4hGD+1KmHjhrNaTMFZsK0CtoKmXzvV9tvbLImpb7kXzAaYBoA9OnZ W2p26aAdxnIzfkSqxadAF80clA6+2RWu4vr1LUJUM4W+8Wnp8FJ7xXfUn7s+mOnW Ip64De4+qm86JrTgFq9AVyyCPt6svma3piuF+Zlbm9MxZXi3r9wr7CIVkwMRkfg= =yRAD -----END PGP SIGNATURE----- -- To unsubscribe, send mail to [email protected].
