On 13.05.2012 17:26, Maxim Koltsov wrote: > Hi, > I' ve been using awesome for a long time and noticed that it provides > no simple way to change wallpaper w/o editing theme. So i created this > patch. It adds extra argument for beautiful.init — wallpaper_cmd > argument. Patch is made on top of 3.4 git branch. Please review and > merge it if you find it ok. > I thought of another way to implement this — make beautiful scan for > wallpaper.* file in one of configuration directories, but i think it's > unconvinient because user won't be able to customize awsetbg's options > or use another wallpaper setter. But if you think it's more > appropriate for awesome, i can remake my patch.
Hi, I have to admit that I didn't like your patch at first (Although I never understood why we have the wallpaper_cmd in themes). Anyway, what do you think about this alternative idea: - Remove all the wallpaper_cmd stuff from beautiful.lua - Add the following code to awesomrc.lua.in (right after beautiful.init()?): if beautiful.wallpaper_cmd then awful.util.spawn(beautiful.wallpaper_cmd, false) end The upside would be that it becomes easier for people to ignore the wallpaper_cmd. They could just remove this code from their config. The downside of course would be that configs gets broken, but I think that we already broke enough configs between 3.4 and git/master. :-) (Also, why does beautiful loop over every screen? There is no screen argument for awful.util.spawn() since quite a while.) Uli -- Q: Because it reverses the logical flow of conversation. A: Why is putting a reply at the top of the message frowned upon? -- To unsubscribe, send mail to [email protected].
