On Tue, Jun 12 2012, Arvydas Sidorenko wrote: Hi Arvydas,,
> Arvydas Sidorenko (14):
> Renamed luaL_reg to luaL_Reg
Merged.
> Unnecessary #define's to static inline functions
Merged.
> luaL_typerror -> luaA_typerror
> Missing file from last commit
Merged and squashed in the former.
> Changed all luaL_typerror to luaA_typerror
Merged.
> Wrapped lua_[gs]etfenv into luaA_[gs]etuservalue
Merged. Did a quick look but I think it's what we want.
> lua_objlen wrapped in luaA_rawlen
Merged.
> Portable way to replace standards Lua funcs
Merged.
> Wrapped luaL_register
Not merged, as you say in the commit message, there's a TODO point and
I'm not sure it works correctly then.
> Replaced already in Lua 5.1 deprecated lua_open()
Merged.
> luaA_registerlib libname NULL segfaults Awesome
I think it's related to "Wrapped luaL_register", but if that's the case
then they should be squashed together.
> Changed lua stack indexing with negative values
Hm, I doubt that's correct. I mean it is, but the problem you're facing
is probably that when this function is called, the stack is not empty,
whereas it should. Could you try to print the stack using the debug
function doing that and eventually fix the real cause?
> Fixed luaA_registerlib to replace deprecated luaL_register
Same as other commits about luaA_registerlib.
I think you can rebase easily on what's in master now and rework your
commit using "git rebase --interactive" to squash commits.
Anyway that's an awesome work (pun intended), congrats.
--
Julien
pgpCuwnfsD7wG.pgp
Description: PGP signature
