Hi,

On 20.01.2013 15:35, Stefan Haller wrote:
> Additionally to handing over the focus to the window this commit raises
> the window too. Otherwise a window which is hidden below other windows can
> request the focus and because the window is not fully exposed, the user is
> unaware which window has the input focus and is actually receiving the
> keystrokes.
> 
> Signed-off-by: Stefan Haller <hali...@googlemail.com>

sorry for being awfully slow. I can't find anything in EWMH which says that this
patch is correct (it only talks about "activating a window", but doesn't say
what that means). However, Fluxbox seems to be doing this, too, so I guess it 
is OK.

Applied. (Let's see what weird bug reports will come in due to this...)

> ---
>  ewmh.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ewmh.c b/ewmh.c
> index 92bd6e8..3e1e3cc 100644
> --- a/ewmh.c
> +++ b/ewmh.c
> @@ -415,8 +415,10 @@ ewmh_process_client_message(xcb_client_message_event_t 
> *ev)
>      }
>      else if(ev->type == _NET_ACTIVE_WINDOW)
>      {
> -        if((c = client_getbywin(ev->window)))
> +        if((c = client_getbywin(ev->window))) {
>              client_focus(c);
> +            client_raise(c);
> +        }
>      }
>  
>      return 0;


-- 
"Every once in a while, declare peace. It confuses the hell out of your enemies"
 - 79th Rule of Acquisition

-- 
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Reply via email to