Re: Patches for the 2.3 branch

[Gregor Best]

On Thu, May 23, 2013 at 11:10:15AM +0200, Gregor Best wrote:
> [...]
> I have also attached another patch that sets the default mwfact for
> new tags to ~0.618, which is the inverse of the golden ratio. IMHO
> this yields a more pleasant split between master and slave windows.
> It's purely cosmetic though.
> [...]

Attached is another patch that fully changes the default mwfact from .5
to .618. I seem to have missed quite a few places in the first
iteration.

-- 
    Gregor Best

From 5ca5ba895be25763a25358d366495d2cc1dd4850 Mon Sep 17 00:00:00 2001
From: Gregor Best <g...@ring0.de>
Date: Fri, 24 May 2013 12:16:17 +0200
Subject: [PATCH] Completely change the default mwfact to .618

The original changes to tag.c missed quite a bunch.

Signed-off-by: Gregor Best <g...@ring0.de>
---
 common/configopts.c | 2 +-
 config.c            | 2 +-
 tag.c               | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/configopts.c b/common/configopts.c
index e69c223..17b2b58 100644
--- a/common/configopts.c
+++ b/common/configopts.c
@@ -482,7 +482,7 @@ cfg_opt_t tag_opts[] =
     /** Default layout for this tag. */
     CFG_STR((char *) "layout", (char *) "tile", CFGF_NONE),
     /** Default master width factor for this tag. */
-    CFG_FLOAT((char *) "mwfact", 0.5, CFGF_NONE),
+    CFG_FLOAT((char *) "mwfact", 0.618, CFGF_NONE),
     /** Default number of master windows for this tag. */
     CFG_INT((char *) "nmaster", 1, CFGF_NONE),
     /** Default number of window columns for this tag. */
diff --git a/config.c b/config.c
index 0176b0a..c2f9869 100644
--- a/config.c
+++ b/config.c
@@ -467,7 +467,7 @@ config_parse_screen(cfg_t *cfg, int screen)
     else
     {
         warn("fatal: no tags found in configuration file\n");
-        tag = tag_new("default", virtscreen->layouts, 0.5, 1, 1);
+        tag = tag_new("default", virtscreen->layouts, 0.618, 1, 1);
         tag_push_to_screen(tag, screen);
     }
 
diff --git a/tag.c b/tag.c
index f7acbcf..9de18a6 100644
--- a/tag.c
+++ b/tag.c
@@ -483,7 +483,7 @@ uicb_tag_create(int screen, char *arg)
     if(!a_strlen(arg))
         return;
 
-    tag = tag_new(arg, globalconf.screens[screen].layouts, 0.5, 1, 1);
+    tag = tag_new(arg, globalconf.screens[screen].layouts, 0.618, 1, 1);
     tag_append_to_screen(tag, screen);
 }
 
-- 
1.8.2.2

pgp7GLwDCdWZg.pgp
Description: PGP signature