THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added:
FS#1211 - Support touchscreen User who did this - Uli Schlachter (psychon) ---------- I'd prefer patches as git-formatted patches (clone the git repo, commit your change to git (with a good commit message referencing FS#1211), git format-patch origin/master.. and attach the resulting file). That way you are tracked as the author of this patch (and I don't have to come up with a commit message). Now on to the patch: What would you say why this does the right thing? All that the patch does is to make all button releases refer to the first(?) button, no matter which button was actually released. I *guess* that replacing " 1 << (ev->detail - 1 + 8))" with something like "ev->response_type == XCB_BUTTON_RELEASE ? 0 : 1 << (ev->detail - 1 + 8))" should work better. I guess it would be best to have some lua code (in the commit message?) that runs a keygrabber and prints all reported events so that it can be verified that lua gets called with the right arguments. (Of course, using the trinary operator for this results in ugly code and I guess it would be better to introduce a new uint16_t mask local variable for this.... But that doesn't matter for the actual idea.) ---------- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1211#comment3810 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to [email protected].
