On Wed, Jan 21, 2009 at 01:49:17PM +0100, Julien Danjou wrote:
> At 1232486207 time_t, Sias Mey wrote:
> > In the past mod j and mod k would scroll the clients in the background
> > of the magnifier up or down and the Master client would be the one that
> > moves out the top or bottom of the list in the background. This made it
> > easy to visually predict what client would be the master and what
> > direction to move in to get to the one you are actually after.
> >
> > It seems that after the new update the order of the clients in the
> > background is somehow inconsistant. mod j and mod k still cycle through
> > the tasklist as usual however the order of the clients in the background
> > seem fairly random now. This makes it very hard to predict what client
> > will be focused by the next focus change. Only having a bunch of urxvt's
> > in the task list doesent really make this easier.
>
> I just pushed a fix.
> The clients were rendered in a linear order with no logical about the
> ones that would be focused next. I hope this is fixed now. It should
> acts as before.
>
> Cheers,
> --
> Julien Danjou
> // ᐰ <[email protected]> http://julien.danjou.info
> // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
Hmmm pulled your fix this morning and experienced some strangeness...
Tracked it down to a small typo. Have attached a patch... even though it
is only a single character change :-P.
Thank you very much for your time.
Cheers,
Sias
diff --git a/lib/awful/layout/suit/magnifier.lua.in b/lib/awful/layout/suit/magnifier.lua.in
index ac48cc6..ee18476 100644
--- a/lib/awful/layout/suit/magnifier.lua.in
+++ b/lib/awful/layout/suit/magnifier.lua.in
@@ -69,7 +69,7 @@ local function magnifier(_, screen)
local fidx
for k, c in ipairs(cls) do
- if k == focus then
+ if c == focus then
fidx = k
break
end
